Minor cleanups in scriptVersionCache #17021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jul 7, 2017
ghost
commented
- Don't introduce a mutable variable just for the sake of reusing it. Use multiple immutable declarations.
- Mark more privates private.
- Remove unnecessary parens.
ghost
force-pushed
the
scriptVersionCache_cleanup
branch
from
748ba13 to
05ee42c
Compare
| interiorNode.add(node); | ||
| charCount += node.charCount(); | ||
| lineCount += node.lineCount(); | ||
| nodeIndex++; |
There was a problem hiding this comment.
How about you move the check of nodeIndex here.
if (nodeIndex >= nodes.length) {
break;
} There was a problem hiding this comment.
I'll make a separate PR for that.
sheetalkamat
approved these changes
Jul 10, 2017
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.